Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(QTree): Allow no-selection-unset to accept 0 as a key #14506

Merged
merged 2 commits into from Sep 29, 2022
Merged

fix(QTree): Allow no-selection-unset to accept 0 as a key #14506

merged 2 commits into from Sep 29, 2022

Conversation

MilosPaunovic
Copy link
Member

Closes #14505

znfgnu
znfgnu approved these changes Sep 28, 2022
View reviewed changes
Copy link

@znfgnu znfgnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you!

@rstoenescu
Copy link
Member

Thanks!
Replaced the nullish coalescing operator though because it requires iOS >= 13.4.

@rstoenescu rstoenescu merged commit 5564afd into quasarframework:dev Sep 29, 2022
rstoenescu added a commit that referenced this pull request Sep 29, 2022
@rstoenescu
fix(QTree): Allow no-selection-unset to accept 0 as a key #14506
3712fd0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znfgnu znfgnu znfgnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QTree with no-selection-unset option set can't accept 0 as a key
3 participants
@MilosPaunovic @rstoenescu @znfgnu