Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix: #14521) Browser hangs when QTree is loaded with relatively large data #14548

Merged
merged 6 commits into from Oct 5, 2022

Conversation

hermit99
Copy link
Contributor

@hermit99 hermit99 commented Oct 4, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
The issue #14521 is mitigated by adding a noTransition prop where tree nodes are not wrapped by QSlideTransition.

This work-around doesn't address QTree's further performance enhancement needs due to the current design & implementation. It seems hard to do so without introducing breaking changes. For example, tree is coupled with nodes, therefore meta, the flat state of tree, is discarded, travelled and rebuilt each time when a node is expanded or ticked, which is too expensive. On a mid-spec PC, rebuilding of 30K nodes tree could take about 200-600ms, causing noticeable lags when expand a parent node.

Mingyu He and others added 6 commits October 3, 2022 19:47
that expand/collapse large tree freezes
No reason to explicitly define a Boolean prop with its Vue-natively default value
@rstoenescu rstoenescu merged commit 70d5604 into quasarframework:dev Oct 5, 2022
@rstoenescu
Copy link
Member

Thank you for contributing!

@rstoenescu
Copy link
Member

This will go into Quasar v2.9.2

rstoenescu added a commit that referenced this pull request Oct 5, 2022
…f; recommended when using relatively large data) #14521 (#14548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants