(fix: #14521) Browser hangs when QTree is loaded with relatively large data #14548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
The issue #14521 is mitigated by adding a noTransition prop where tree nodes are not wrapped by QSlideTransition.
This work-around doesn't address QTree's further performance enhancement needs due to the current design & implementation. It seems hard to do so without introducing breaking changes. For example, tree is coupled with nodes, therefore meta, the flat state of tree, is discarded, travelled and rebuilt each time when a node is expanded or ticked, which is too expensive. On a mid-spec PC, rebuilding of 30K nodes tree could take about 200-600ms, causing noticeable lags when expand a parent node.