Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QBtnDropdown): Support transition props #14585

Merged
merged 1 commit into from Oct 12, 2022
Merged

feat(QBtnDropdown): Support transition props #14585

merged 1 commit into from Oct 12, 2022

Conversation

xuzuodong
Copy link
Contributor

@xuzuodong xuzuodong commented Oct 9, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

I want to add transition to q-btn-dropdown, but then I noticed it doesn't have related props in spite of inheriting from q-menu. This PR adds transition support to QBtnDropdown

<q-btn-dropdown 
  transition-show="jump-down" 
  transition-hide="jump-up" 
  transition-duration="1000"
>
  <q-list>...</q-list>
</q-btn-dropdown>

屏幕录制2022-10-09 16 57 39

@rstoenescu rstoenescu merged commit f90da4b into quasarframework:dev Oct 12, 2022
@rstoenescu
Copy link
Member

Thanks for contributing!

@rstoenescu
Copy link
Member

This will go into v2.9.3

@xuzuodong xuzuodong deleted the dev-btn-dropdown-transition branch October 13, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants