Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QBreadcrumbsEl has useless "ripple" prop #14602

Closed
KareemDa opened this issue Oct 11, 2022 · 4 comments
Closed

QBreadcrumbsEl has useless "ripple" prop #14602

KareemDa opened this issue Oct 11, 2022 · 4 comments
Labels
area/components kind/docs 📄 Qv2 🔝 Quasar v2 issues

Comments

@KareemDa
Copy link
Contributor

Description

Check Breadcrumbs EL Docs Page

It has a prop called: "ripple" but this prop is never used

You can check the component. It's never used there

Documentation Section URL

https://quasar.dev/vue-components/breadcrumbs#qbreadcrumbsel-api

Flavour

No response

Areas

Components (quasar)
@KareemDa KareemDa added kind/docs 📄 Qv2 🔝 Quasar v2 issues labels Oct 11, 2022
@MilosPaunovic
Copy link
Member

Seems like you are correct. Would you care to make a PR for a fix?

@KareemDa
Copy link
Contributor Author

Sure. I'll push it within 1 hour

@KareemDa
Copy link
Contributor Author

@MilosPaunovic
Kindly check 14603

@rstoenescu
Copy link
Member

Fixed by PR (removed non-existent prop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/components kind/docs 📄 Qv2 🔝 Quasar v2 issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rstoenescu @KareemDa @MilosPaunovic