Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(a11y): improve a11y for components #14609

Merged
merged 1 commit into from Oct 13, 2022
Merged

feat(a11y): improve a11y for components #14609

merged 1 commit into from Oct 13, 2022

Conversation

pdanpdan
Copy link
Collaborator

  • QBadge: role status instead of alert
  • QDialog: role dialog
  • QBottomSheet: role list/listitem
  • QItem: role listitem
  • QList: role list
  • QOptionGroup: role group if not radiogroup
  • QPagination: role navigation; aria-label; aria-current
  • QToolbar: role toolbar
  • QTooltip: role tooltip instead of complementary
  • QToggle: role switch

@pdanpdan
feat(a11y): improve a11y for components
1814390 
- QBadge: role status instead of alert
- QDialog: role dialog
- QBottomSheet: role list/listitem
- QItem: role listitem
- QList: role list
- QOptionGroup: role group if not radiogroup
- QPagination: role navigation; aria-label; aria-current
- QToolbar: role toolbar
- QTooltip: role tooltip instead of complementary
- QToggle: role switch
@rstoenescu rstoenescu merged commit 3913d4e into quasarframework:dev Oct 13, 2022
@pdanpdan pdanpdan deleted the feature/v2-a11y branch October 13, 2022 10:51
yusufkandemir added a commit that referenced this pull request Nov 17, 2023
@yusufkandemir
fix(docs): improve a11y of footer with role="list"
ae076cc 
QList used to have role="list" by default, added with #14609. 
But, it was later removed with #14784 since it's also used with the menu role commonly.
So, now QItems have role="listitem" but their parent(QList) doesn't have the list role, which is invalid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pdanpdan @rstoenescu