Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): Localization file for Kazakh renamed (no issue in github) #14985

Merged
merged 1 commit into from Dec 17, 2022
Merged

fix(ui): Localization file for Kazakh renamed (no issue in github) #14985

merged 1 commit into from Dec 17, 2022

Conversation

o-r-e
Copy link
Contributor

@o-r-e o-r-e commented Nov 26, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

This change will break all dependencies to "ui/lang/kz.js" and "ui/lang/kz.mjs".
Migration path for existing applications: change dependencies to "ui/lang/kk.js" and "ui/lang/kk.mjs".

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Locale "Kazakh" in file name must be "kk", not "kz"; more details about it can be found in discussion #12663

@o-r-e
fix(ui): Localization file for Kazakh renamed (no issue in github)
b48b0df 
Rename localization file(s) for Kazakh.
Locale in file name must be "kk", not "kz",
more details about it can be found in discussion #12663

BREAKING CHANGE:
This change will break all dependencies to "ui/lang/kz.js" and "ui/lang/kz.mjs"
@o-r-e o-r-e marked this pull request as ready for review November 26, 2022 11:04
@rstoenescu rstoenescu merged commit 9e4090b into quasarframework:dev Dec 17, 2022
@rstoenescu
Copy link
Member

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@o-r-e @rstoenescu