Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOSE on select is redundant #157

Closed
murbanowicz opened this issue Nov 2, 2016 · 6 comments
Closed

CLOSE on select is redundant #157

murbanowicz opened this issue Nov 2, 2016 · 6 comments

Comments

@murbanowicz
Copy link
Contributor

It is redundant and really useless.
To prove my word, look at other ui libs - you will not find it anywhere in any respected library. It even looks strange.

@rstoenescu
Copy link
Member

The point of a framework is to offer components as generic as possible with as many features as possible. There may be cases when the developer wants to programmatically open the select popover. The argument that X other framework doesn't do this is not valid. Quasar is better than other frameworks. Please reopen with a solid argumentation.

@murbanowicz
Copy link
Contributor Author

You're right. Then, there should be optional parameter
close='false' to disable it or enable - depends which one will be default.
Then Q will be really better than others! :)

@rstoenescu
Copy link
Member

You've got disable Boolean property. Case closed. Q wins :)

@murbanowicz
Copy link
Contributor Author

Not that easy! :)
I would really like to be able to not show CLOSE button on the top of options of multiselect ( type='checkbox.
I hope you get what I mean?
https://snag.gy/aOG3Zx.jpg

@rstoenescu
Copy link
Member

rstoenescu commented Nov 2, 2016

Aha. You are referring to something else. Ok, will add a property. Do you care to make a PR? It's easy.

EDIT: Actually scratch that. I got a nice idea and will implement it in next Q. Anyway, that "close" button currently has its purpose. It doesn't forces the user to find an area with no click/tap events attached so he/she can close that popup. When on a narrow screen like a mobile phone that can be a small issue ;)

@murbanowicz
Copy link
Contributor Author

Agree - should be shown on small screens as default, but on larger screens we need at least choice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants