Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix LoadingBar defaults type #16049

Merged

Conversation

yusufkandemir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)

Other information:
#15945 (comment)

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Build Results

JSON API

📜 Changes detected:

diff --git a/./current-build/api/LoadingBar.json b/./pr-build/api/LoadingBar.json
index 1843183..5678856 100644
--- a/./current-build/api/LoadingBar.json
+++ b/./pr-build/api/LoadingBar.json
@@ -8,7 +8,7 @@
     "propName": "loadingBar",
     "type": "Object",
     "tsType": "QLoadingBarOptions",
-    "desc": "QAjaxBar component props, EXCEPT for 'hijack-filter'",
+    "desc": "QAjaxBar component props, EXCEPT for 'hijack-filter' in quasar.config file (if using Quasar CLI)",
     "examples": [
       "{ position: 'bottom', reverse: true }"
     ]
@@ -51,7 +51,7 @@
           "type": "Object",
           "tsType": "QLoadingBarOptions",
           "required": true,
-          "desc": "QAjaxBar component props, EXCEPT for 'hijack-filter'",
+          "desc": "QAjaxBar component props",
           "examples": [
             "{ position: 'bottom', reverse: true }"
           ]

Types

📜 Changes detected:

diff --git a/./current-build/types/api/qloadingbar.d.ts b/./pr-build/types/api/qloadingbar.d.ts
index 5b436e6..d2de8a5 100644
--- a/./current-build/types/api/qloadingbar.d.ts
+++ b/./pr-build/types/api/qloadingbar.d.ts
@@ -1,3 +1,3 @@
 import { QAjaxBarProps } from "quasar";
 
-export type QLoadingBarOptions = Omit<QAjaxBarProps, "hijackFilter">;
+export type QLoadingBarOptions = QAjaxBarProps;
diff --git a/./current-build/types/index.d.ts b/./pr-build/types/index.d.ts
index a97875b..a62a907 100644
--- a/./current-build/types/index.d.ts
+++ b/./pr-build/types/index.d.ts
@@ -322,7 +322,7 @@ export interface LoadingBar {
   increment: (amount?: number) => void;
   /**
    * Set the inner QAjaxBar's props
-   * @param props QAjaxBar component props, EXCEPT for 'hijack-filter'
+   * @param props QAjaxBar component props
    */
   setDefaults: (props: QLoadingBarOptions) => void;
 }
@@ -14173,7 +14173,7 @@ declare module "./config.d.ts" {
       customClass?: string;
     };
     /**
-     * QAjaxBar component props, EXCEPT for 'hijack-filter'
+     * QAjaxBar component props, EXCEPT for 'hijack-filter' in quasar.config file (if using Quasar CLI)
      */
     loadingBar?: QLoadingBarOptions;
     notify?: {

@rstoenescu rstoenescu merged commit 41a9e7e into quasarframework:dev Jul 6, 2023
1 check passed
@yusufkandemir yusufkandemir deleted the fix-loadingbar-defaults-types branch July 6, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants