Regression on local filter functions?

[timkral]

HI,

I'd like to use a local function as outlined in the Ruleguard by example documentation, but I encountered an error: expected a m method call, found ... . I then tried copying the exact example from the documentation and encountered the same error:

✗ ruleguard -c 1 -rules rcore/lib/linter/rules-services.go ./...
ruleguard: load rules: parse rules file: irconv error: rcore/lib/linter/rules-services.go:34: expected a m method call, found isExported := func(v dsl.Var) bool {
	return v.Text.Matches(`^\p{Lu}`)
}

Is this a feature that's still supported?

[timkral]

I also tried this:

// isExported reports whether bound matcher var
// represents exported Go identifier.
var isExported = func(v dsl.Var) bool {
	return v.Text.Matches(`^\p{Lu}`)
}

func exposedMutex(m dsl.Matcher) {

	// isExported() is more readable than `^\p{Lu}`
	// regular expression itself.

	m.Match(`type $name struct { $*_; sync.Mutex; $*_ }`).
		Where(isExported(m["name"])).
		Report("do not embed sync.Mutex")

	m.Match(`type $name struct { $*_; sync.RWMutex; $*_ }`).
		Where(m["name"].Text.Matches(`^\p{Lu}`)).
		Report("don not embed sync.RWMutex")
}

But got a different error:

✗ ruleguard -c 1 -rules rcore/lib/linter/rules-services.go ./...
ruleguard: load rules: parse rules file: irconv error: rcore/lib/linter/rules-services.go:34: unsupported expr: m["name"] (*ast.IndexExpr)

[quasilyte]

Hi.
Which version are you using? Only the development branch contains this feature, I'll roll a release in the following week or two.

[timkral]

Hi @quasilyte ,

Got it, thanks for the response. I'm using version v0.3.13. Ultimately, I'd like to use the feature in the golangci-lint tool so I will wait for a new release and version upgrade there.

-Tim

[timkral]

Hi @quasilyte ,

I was wondering if there was any updates on releasing a new version to include these changes.

Thanks.
-Tim

[quasilyte]

I would like to investigate and fix #317 if it's reproducible.
After that, a new release can be made.
I could try poking at that issue this weekend.