Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-grub: serial console autogeneration for default code args #1003

Open
stdweird opened this issue Dec 24, 2016 · 3 comments
Open

ncm-grub: serial console autogeneration for default code args #1003

stdweird opened this issue Dec 24, 2016 · 3 comments
Labels
question

Comments

@stdweird
Copy link
Member

when specifying the kernelargs for the individual kernel entries, any console settings are replaced by settings from /hardware/console/serial.

this feature however is missing when setting the default kernel args (and is easy to add).
impact wrt backwards incompatibility: what happens is a search and replace, so any current args in profile with console=ttyS matching would be replaced with generated settings

relevant code
https://github.com/quattor/configuration-modules-core/pull/999/files#diff-bf668a94c3349c53f93cae1029a287f1R479
@stdweird stdweird added this to the 17.2 milestone Dec 24, 2016
@stdweird stdweird mentioned this issue Dec 24, 2016
Merged
@jrha jrha modified the milestones: 17.3, 17.2 Feb 27, 2017
@jrha jrha removed this from the 17.3 milestone Mar 27, 2017
@jrha
Copy link
Member

jrha commented Mar 27, 2017

@stdweird I assume this isn't going anywhere soon?

@stdweird
Copy link
Member Author

we don't really use this. but i think it's relevant for MS @ned21 @ajf8 ?

@ned21
Copy link
Contributor

ned21 commented Mar 28, 2017

Yes, very important for us. What's the ask here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ned21 @jrha @stdweird