Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-symlink: use CAF::Process to execute commands #502

Open
jouvin opened this issue May 9, 2015 · 2 comments
Open

ncm-symlink: use CAF::Process to execute commands #502

jouvin opened this issue May 9, 2015 · 2 comments

Comments

@jouvin
Copy link
Contributor

jouvin commented May 9, 2015

ncm-symlink allows to specify commands whose output are used to build symlink target path. These commands are currently executed with qx (method expand_cmds). This should be replaced by CAF::Process.
Also to limit the risk of using this feature for command injection, look if the command could be executed as nobody, restricting the commands used to those involving no modification or file writing... We could also require the full path of the command to be specified and for backward compatibility assume /usr/bin for the commands without a path.
@jouvin jouvin added this to the 15.6 milestone May 9, 2015
@jouvin jouvin mentioned this issue May 9, 2015
Merged
@ned21
Copy link
Contributor

ned21 commented May 11, 2015

+1 for comprehensive NoAction support in this component, not just the command execution part!

@jrha jrha modified the milestones: 16.2, 15.8 Aug 11, 2015
@ned21 ned21 mentioned this issue Dec 9, 2015
Open
@jrha jrha removed this from the 16.4 milestone Dec 12, 2015
@jouvin
Copy link
Contributor Author

jouvin commented Jan 15, 2016

See #683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ned21 @jrha @jouvin