New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template validation as part of pull requests #38
Comments
@JensTimmerman we need to take a look at this |
With the last version of create-vanilla-SCDB.sh (and get-template-library, release#37), it should be much easier to use it as the test associated with the template-library-xxx repos. We just need to add an option passing the commit to "merge" before the test. I can help with this if you tell me what are the parameters passed by GitHub to the script when calling it as part of a PR. |
Lets see if we can get this done for 14.8 |
there are 2 ways forward imho:
following relevant GIT_ variables are available during the jenkins job
and the current checkout is in (even better, the vanilla script has a -jenkins option and just figures it all out using the above variables) |
Thanks. I'm trying to come up with an implementation soon... (but probably not today). |
After merging quattor/release#44, you should be able to use A typical calling sequence for adding a pull request to the template library before compilinig is: create-vanilla-SCDB.sh -F --pull-request template-library-grid:almumontiel:apel:umd-3 HEAD This will merge the pull request corresponding to branch Note that the Let me know if the way to specify the pull request is usable in the GitHub/Jenkins context or if you need a different way of passing the information. The important thing is to be able to pass to the script the source repo/branch to use, even though it is already checked out by GitHub because we cannot just copy the branch content to the standard repo clones as we'll downgrade some files. We really need to ask Git to do a real merge. |
When a pull request is created in template-library-grid jenkins will check out the If I get your workflow correctly you want it to check out the SCDB master branch, and then use your script to merge in the state of the pull request? So if I get this correctly the only thing you need to do in the template-library-xxx pull request builder is check out the SCDB master branch, and run a script that takes the current directory instead of checking something out, if this is possible? |
The problem is that we cannot do anything useful (in term of testing) with any single template-library-xxx repos. We need them all (like Pokemons!). This is why the pre-merge done by Jenkins is not really useful in our case.
|
Ok, this makes sense, can you ping me back here after quattor/release#44 is merged, I will look into it. |
I just merge it to allow to proceed with this issue. Be sure to take the last revision of SCDB trunk as I also just merged the |
@JensTimmerman I'll move the target for this to 14.10 as it doesn't seem like it'll happen by next week. |
@jouvin So as I understand it now:
But it is unclear to me if step 1 is done by the |
Not a blocker, bumped. |
@JensTimmerman sorry for overlooking your last comment. Typical options for utils/scdb/create-vanilla-SCDB.sh -F --pull-request template-library-grid:jouvin:umd3-glue2:umd-3 HEAD The only thing that needs to be customized at each executiong is the |
@jouvin i'm testing latest scdb master, i get
it would also be nice if the script would use
so i can change the /tmp location on jenkins |
The error you report is weird... Are you sure that you use the last version of BTW, I spent some time today fixing I'm adding the modification you asked for to be able to relocate |
@jouvin it was a clone in a new directory. i'll look into it again this week |
@stdweird Looking again at the error (I missed the long line...), I think this is caused by a bug I fixed during the last day of the workshop, where the shell was |
@jouvin ah yes, you're right
|
Download the last version of |
@stdweird let me know if there is anything I could do to help getting this working... |
It'd be good to have it working before 15.4... |
@stdweird what can we do to complete this...??? Issues found during RC2 would have been avoided if running the suggested unit tests... I'm reassigning to 15.6 with the hope that we can get it working before that. |
As discussed during the workshop, it'd be nice to have in all template-library-xxx repositories a validation test associated with pull requests. The initial implementation of the test could be the execution of create-vanilla-SCDB.sh (in SCDB repo). This script pulls down everything needed to compile the examples and compile them. We may just have to check that the script properly report a failure status.
The text was updated successfully, but these errors were encountered: