Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updater: Always use bzr revno to get Ubuntu db's revision number. #11

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

Quentin-M
Copy link
Contributor

It appears that bzr is localized and that its output differs version to version.

Fixes #7

out, _ = utils.Exec(pathToRepo, "bzr", "revno")
revno, err := strconv.Atoi(string(out[:len(out)-1]))
if err != nil {
log.Errorf("could not parse Ubuntu repository revision number: %s. output: %s", err, string(out))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to cast out to strting

@silas
Copy link

silas commented Nov 16, 2015

LGTM

Quentin-M pushed a commit that referenced this pull request Nov 16, 2015
updater: Always use `bzr revno` to get Ubuntu db's revision number.
@Quentin-M Quentin-M merged commit 635f4ec into quay:master Nov 16, 2015
@Quentin-M Quentin-M deleted the bzr_parsing branch November 16, 2015 23:34
@jzelinskie jzelinskie added kind/bug things are not as they seem reviewed/lgtm labels Mar 12, 2016
Allda added a commit to Allda/clair that referenced this pull request May 22, 2019
Add new formatter for Kafka logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug things are not as they seem
Development

Successfully merging this pull request may close these issues.

None yet

3 participants