Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass -z to tar #25

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Don't pass -z to tar #25

merged 1 commit into from
Nov 23, 2015

Conversation

fatalbanana
Copy link
Contributor

AFAICT docker save will produce an uncompressed tar archive.

This prevented successful run of analyze-local-images:

2015/11/23 13:59:30 - Could not save image: 
gzip: stdin: not in gzip format
tar: Child died with signal 13
tar: Error is not recoverable: exiting now

The patch fixed it. :)

If docker save will in fact produce compressed output?- & one's implementation of tar is not capable of self-identifying compression, then perhaps this would break things. :\

@Quentin-M
Copy link
Contributor

You are right ! Good catch, my tar implementation is capable of skipping -z the archive is not actually gzip'd.

Can you just edit your commit message to make it more standard ? Something like contrib: Don't pass -z to tar in analyze-local-images ?

Thanks for your contribution.

Quentin-M pushed a commit that referenced this pull request Nov 23, 2015
@Quentin-M Quentin-M merged commit fdbe1eb into quay:master Nov 23, 2015
@jzelinskie jzelinskie added area/dev tooling related to tools used by developers kind/bug things are not as they seem reviewed/lgtm labels Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev tooling related to tools used by developers kind/bug things are not as they seem
Development

Successfully merging this pull request may close these issues.

None yet

3 participants