pgsql: Do not insert entry in Vulnerability_FixedIn_Feature if existing #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this PR lands, it should be backported to the stable branch(es). |
jzelinskie
suggested changes
Nov 11, 2016
| ) | ||
| SELECT 'exi', id FROM Vulnerability_FixedIn_Feature WHERE vulnerability_id = $1 AND feature_id = $2 | ||
| UNION | ||
| SELECT 'new', id FROM new_fixedinfeature` |
There was a problem hiding this comment.
Let's change this first value to be a boolean and bind it to a Go variable named "created" at the callsite.
|
We really need to break the database tests into different functions that describe the scenario they're testing rather than having one giant monolithic function for each method in the interface. |
|
@jzelinskie #264 + ec0aad9. Thank you! |
jzelinskie
approved these changes
Nov 13, 2016
|
LGTM. I set a reminder to backport these changes on Monday. |
jzelinskie
pushed a commit
that referenced
this pull request
Nov 14, 2016
pgsql: Do not insert entry in Vulnerability_FixedIn_Feature if existing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238