worker: clarify maxFileSize purpose #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentin-M
reviewed
Dec 19, 2016
| @@ -30,7 +30,9 @@ const ( | |||
| // Increased each time the engine changes. | |||
| Version = 3 | |||
|
|
|||
| // maxFileSize is the maximum size of a single file we should extract. | |||
| // maxFileSize enforces a maximum size of a single file within a tarball that | |||
| // will be extracted. This protects against against malicious layers that may | |||
Quentin-M
approved these changes
Dec 20, 2016
|
@jzelinskie : any chance we can make it a variable in config.yaml? I believe at least 2 QE customers are interested in scanning large layers. |
|
@alekssaul As the comment in the code and as my comment in the initial issue state, this value has nothing to do with the size of the layer Clair can analyze but with the size of the targeted files we extract to parse informations from (e.g. /etc/os-release, /var/lib/dpkg, etc). These files today have literally no reason to exceed 200 MiB except clear abuse attempt. Clair can analyze layers of any size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237.