Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database: Improve InsertVulnerabilities. #33

Merged
merged 1 commit into from
Dec 4, 2015
Merged

database: Improve InsertVulnerabilities. #33

merged 1 commit into from
Dec 4, 2015
+36 −68

Conversation

Quentin-M
Copy link
Contributor

No description provided.

@josephschorr
Copy link
Contributor

What are the specific improvements this PR addresses?

@Quentin-M
Copy link
Contributor Author

  • Improves readability.
  • Fixes logic mistakes in FixedInNodes updating block.
  • Remove an long and quite useless test for an unlikely situation that would not do difference anyways.

@jzelinskie
Copy link
Contributor

LGTM

Quentin-M pushed a commit that referenced this pull request Dec 4, 2015
Merge pull request #33 from Quentin-M/insertvulns
46fffdf 
database: Improve InsertVulnerabilities.
@Quentin-M Quentin-M merged commit 46fffdf into quay:master Dec 4, 2015
@Quentin-M Quentin-M deleted the insertvulns branch December 4, 2015 20:50
@jzelinskie jzelinskie added area/testing related to improving test coverage kind/cleanup no functional changes, only reorganization reviewed/lgtm labels Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/testing related to improving test coverage kind/cleanup no functional changes, only reorganization
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quentin-M @josephschorr @jzelinskie