api/database: Add the ability to delete layers #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,6 +131,59 @@ func InsertLayer(layer *Layer) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // DeleteLayer delete the specified layer and every layers that are based on that one, recursively. | |||
There was a problem hiding this comment.
DeleteLayer deletes the specified layer and any child layers that are dependent on the specified layer.
Also, comments in Go are 80 chars per line
There was a problem hiding this comment.
Dang it. Such a pain in the butt to switch back and forth between 100C (Python) to 80C (Go).
There was a problem hiding this comment.
I do use it through https://atom.io/packages/go-plus, automatically on save but it does not wrap comments / enforce line length afaik.
|
LGTM |
Quentin-M
pushed a commit
that referenced
this pull request
Dec 4, 2015
api/database: Add the ability to delete layers
jzelinskie
added
kind/feature request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.