Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: only extract layers from history #367

Merged
merged 1 commit into from
Apr 19, 2017
Merged

contrib: only extract layers from history #367

merged 1 commit into from
Apr 19, 2017

Conversation

jzelinskie
Copy link
Contributor

@jzelinskie jzelinskie commented Apr 19, 2017 •
edited
Loading

This tool was written before v2 existed and I'm not sure if our assumptions are still true.

@jzelinskie
contrib: only extract layers from history
e772be5 
This tool was written before v2 existed and deduplicated and listed
layers out of order in their manifests.
@jzelinskie jzelinskie added the kind/bug things are not as they seem label Apr 19, 2017
@Quentin-M
Copy link
Contributor

I need an auto-approver script.

@jzelinskie jzelinskie merged commit e639367 into quay:master Apr 19, 2017
@jzelinskie jzelinskie deleted the analyze-layers-v2 branch April 19, 2017 20:27
@jzelinskie jzelinskie mentioned this pull request Apr 20, 2017
Merged
josuesdiaz pushed a commit to josuesdiaz/clair that referenced this pull request Apr 28, 2017
contrib: Revert "Merge pull request quay#367 from jzelinskie/analyze-…
f3840f3 
…layers-v2"

This reverts commit e639367, reversing
changes made to f3848d9. Issue involved
the docker history command providing missing fs layers that were not in
the saved image. Revert commit to using the manifest file again.
KeyboardNerd pushed a commit to KeyboardNerd/clair that referenced this pull request Feb 2, 2018
@jzelinskie
Merge pull request quay#367 from jzelinskie/analyze-layers-v2
ba5cd9a 
contrib: only extract layers from history
KeyboardNerd pushed a commit to KeyboardNerd/clair that referenced this pull request Feb 2, 2018
@jzelinskie
contrib: add missing :=
263e109 
I accidentally didn't push this commit to quay#367.
Fixes quay#368.
KeyboardNerd pushed a commit to KeyboardNerd/clair that referenced this pull request Feb 2, 2018
contrib: Revert "Merge pull request quay#367 from jzelinskie/analyze-…
fdefeb7 
…layers-v2"

This reverts commit e639367, reversing
changes made to f3848d9. Issue involved
the docker history command providing missing fs layers that were not in
the saved image. Revert commit to using the manifest file again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quentin-M Quentin-M Quentin-M approved these changes

Assignees
No one assigned
Labels
kind/bug things are not as they seem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzelinskie @Quentin-M