Add logging #371
Merged
Add logging #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentin-M
reviewed
Apr 25, 2017
| @@ -210,7 +210,7 @@ func detectFeatureVersions(name string, files tarutil.FilesMap, namespace *datab | |||
| continue | |||
| } | |||
|
|
|||
| log.Warningf("layer %s: Layer's namespace is unknown but non-namespaced features have been detected", name) | |||
| log.Warningf("Namespace unknown for feature %s %s, in layer %s", feature.Feature.Name, feature.Version, name) | |||
There was a problem hiding this comment.
why removing the prefix? the format is used everywhere else.
There was a problem hiding this comment.
ideally, we'd like to switch to logrus and use structured messages though!
There was a problem hiding this comment.
I'm going to make a follow up PR doing that.
KeyboardNerd
pushed a commit
to KeyboardNerd/clair
that referenced
this pull request
Feb 2, 2018
Add logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add some logging information that was useful to me when working with clair.