contrib: Fix analyze_local_images when image has missing layers #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, It looks like this is (sadly) the best way to do this. I had reproduced a bug locally using this method, but it seems far less likely to occur than to have the command have missing layers. Can you make your commit simply a |
josuesdiaz
force-pushed
the
fix_analyze_local
branch
from
c11146c
to
f3840f3
Compare
|
Ya sure, sorry should have thought to do that in the first place. Updated the branch, and you should see the revert only in PR now. |
KeyboardNerd
pushed a commit
to KeyboardNerd/clair
that referenced
this pull request
Feb 2, 2018
contrib: Fix analyze_local_images when image has missing layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was originally addressed in #69, but looks to have been
reverted since then. As of right now, certain images that have missing
layers or layers that are not in the docker save output will cause an error
with the analyze_local_images command. Switching back to reading layers
from manifest.json file from docker save of the image.