convert to structured logging using logrus #383 #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
suggested changes
May 4, 2017
ext/featurens/driver.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| if namespace != nil { | ||
| log.Debugf("detected namespace %s: %#v", name, namespace) | ||
| log.WithFields(log.Fields{"name": name, "namespace": fmt.Sprintf("%#v", namespace)}).Debug("detected namespace") |
There was a problem hiding this comment.
"namespace": namespace.Name
pkg/formatter/formatter.go
Outdated
| ts := now.Format("2006-01-02 15:04:05") | ||
| ms := now.Nanosecond() / 1000 | ||
|
|
||
| data["Time"] = (fmt.Sprintf("%s.%06d", ts, ms)) |
changed from capnslog to logrus for logging JSON structured message. finished issue quay#383
jzelinskie
approved these changes
May 4, 2017
|
heck yeah~! |
KeyboardNerd
pushed a commit
to KeyboardNerd/clair
that referenced
this pull request
Feb 2, 2018
convert to structured logging using logrus quay#383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.