worker: fixed duplicated ns and ns not inherited bug #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gotta fix the tests |
KeyboardNerd
force-pushed
the
multiplens
branch
2 times, most recently
from
4b64514
to
78efc0d
Compare
jzelinskie
suggested changes
Jun 3, 2017
worker.go
Outdated
| func detectNamespaces(name string, files tarutil.FilesMap, parent *database.Layer) (namespaces []database.Namespace, err error) { | ||
| namespaces, err = featurens.Detect(files) | ||
| nsSet := map[string]*database.Namespace{} | ||
| nsCurrent, err := featurens.Detect(files) // detect the namespaces of current layer's files |
There was a problem hiding this comment.
no need for this comment; trailing comments in Go are usually discouraged anyways
worker.go
Outdated
| } | ||
|
|
||
| // set the layers |
There was a problem hiding this comment.
no need for this comment either, it's really clear what's happening
jzelinskie
approved these changes
Jun 5, 2017
KeyboardNerd
pushed a commit
to KeyboardNerd/clair
that referenced
this pull request
Feb 2, 2018
worker: fixed duplicated ns and ns not inherited bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.