update first instructions for k8s with helm #459
Conversation
Documentation/running-clair.md
Outdated
| @@ -44,14 +44,15 @@ A [PostgreSQL 9.4+] database instance is required for all instructions. | |||
| #### Kubernetes | |||
There was a problem hiding this comment.
Let's change this to be #### Kubernetes (Helm)
Documentation/running-clair.md
Outdated
| @@ -44,14 +44,15 @@ A [PostgreSQL 9.4+] database instance is required for all instructions. | |||
| #### Kubernetes | |||
|
|
|||
| If you don't have a local Kubernetes cluster already, check out [minikube]. | |||
| This also requires [helm]. | |||
There was a problem hiding this comment.
How does something like this sound instead?
This assumes you've already ran
helm initand you have access to a currently running instance of Tiller.
Documentation/running-clair.md
Outdated
|
|
||
| [minikube]: https://github.com/kubernetes/minikube | ||
| [helm]: https://github.com/kubernetes/helm |
There was a problem hiding this comment.
I don't think this is necessary anymore.
Documentation/running-clair.md
Outdated
| kubectl create secret generic clairsecret --from-file=./config.yaml | ||
| kubectl create -f clair-kubernetes.yaml | ||
| cd clair/contrib/helm | ||
| helm install clair |
There was a problem hiding this comment.
we should probably instruct users to create their own values.yaml:
cd clair/contrib/helm
cp values.yaml ~/my_custom_values.yaml
vi ~/my_custom_values.yaml
helm install clair -f ~/my_custom_values.yaml
There was a problem hiding this comment.
thanks for the quick feedback @jzelinskie
|
@jzelinskie I made suggested edits -- thanks for the quick review |
Documentation/running-clair.md
Outdated
|
|
||
| If you don't have a local Kubernetes cluster already, check out [minikube]. | ||
| This assumes you've already ran helm init and you have access to a currently running instance of Tiller. |
There was a problem hiding this comment.
Put helm init in upticks so that it stands out as a command.
`helm init`
There was a problem hiding this comment.
yikes, good catch
|
Thanks @jzelinskie -- comment addressed. |
update first instructions for k8s with helm
It appears the preferred method of installation for kubernetes is to use helm.
I updated documentation to reflect that.