database: Fix incorrect behavior of toValue when reading empty strings. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not a fan of defensive programming for "what if" scenarios. If something is introducing an empty path, that's a bug, not this code. Is there ever a scenario when the path could be empty and it isn't a bug? |
There is apparently no reason to ignore empty results - it was probably the case in the past (`null` value). ["", "v"] should be considered invalid by toValue() because it represents two values. ["", "v"] should be returned as it by toValues(), not trimming "". Tests passes, it will hopefully not cause any issue in prod.
Quentin-M
force-pushed
the
fix_sql_tovalue
branch
from
1d5b352
to
32747a5
Compare
|
Updated. It basically makes toValues() and toValue() stop ignoring empty strings. |
|
LGTM |
Quentin-M
pushed a commit
that referenced
this pull request
Dec 16, 2015
database: Fix incorrect behavior of toValue when reading empty strings.
This was referenced Jan 4, 2019
This was referenced May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are two strings for a path (ie. "", "yes"), always return "yes"
and never "".
Unlikely to happen but, still.