Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config.yaml.sample #469

Merged
merged 1 commit into from
Oct 16, 2017
Merged

Fix config.yaml.sample #469

merged 1 commit into from
Oct 16, 2017

Conversation

zamarrowski
Copy link
Contributor

Changed address of Clair API to bind correctly.

Changed address of Clair API to bind correctly.
@jzelinskie
Copy link
Contributor

jzelinskie commented Oct 13, 2017

Binding to 0.0.0.0 actually is a shortcut for saying "bind on all interfaces".
If a user is just trying to get something running it's more likely to function than localhost, especially if the user is trying to access the instance from a non-local network (or a virtual network that runs, say, docker).

I'm willing to accept this change if you have a good argument against this.

@zamarrowski
Copy link
Contributor Author

Yeah, when you bind to 0.0.0.0 you are saying "bind on all interfaces" inside container. In fact, the Docker documentation says:

You can see that Docker has exposed these container ports on 0.0.0.0, the wildcard IP address that will match any possible incoming port on the host machine.

We needed change to 0.0.0.0 because we couldn't access to the API from outside of container.

Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I totally read the diff wrong! I thought we already were using 0.0.0.0.
LGTM

@jzelinskie jzelinskie merged commit fbd8407 into quay:master Oct 16, 2017
KeyboardNerd pushed a commit to KeyboardNerd/clair that referenced this pull request Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants