Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dumb-init to Dockerfile Entrypoint #477

Merged
merged 3 commits into from
Oct 16, 2017
Merged

Add dumb-init to Dockerfile Entrypoint #477

merged 3 commits into from
Oct 16, 2017

Conversation

bseb
Copy link

@bseb bseb commented Oct 13, 2017

This allows for proper zombie process reaping. See discussion in #441

@bseb bseb mentioned this pull request Oct 13, 2017
@jzelinskie
Copy link
Contributor

jzelinskie commented Oct 13, 2017

It looks like Alpine has a package for dumb-init that we could use instead of curling it down. This URL looks like it's for edge, though. I'm not sure if it's available on stable.

@bseb
Copy link
Author

bseb commented Oct 13, 2017

@jzelinskie Looks like dumb-init is indeed available in the alpine repos for 1.8. Ive changed the Dockerfile accordingly.

Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jzelinskie jzelinskie merged commit db91b91 into quay:master Oct 16, 2017
KeyboardNerd pushed a commit to KeyboardNerd/clair that referenced this pull request Feb 2, 2018
Add dumb-init to Dockerfile Entrypoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants