Usage of running clair via docker is wrongly written. #484
Conversation
|
|
|
@jzelinskie I mean that in sample configuration localhost is used to connect to postgres. But when container is running in bridge network, there is no way to access localhost. I think that the document about running clair via docker works wrong. |
|
Ah! It turns out that you can elide Sorry about that. |
| @@ -77,7 +77,7 @@ If this error is raised, manually execute `docker-compose start clair`. | |||
| $ mkdir $PWD/clair_config | |||
| $ curl -L https://raw.githubusercontent.com/coreos/clair/master/config.yaml.sample -o $PWD/clair_config/config.yaml | |||
| $ docker run -d -e POSTGRES_PASSWORD="" -p 5432:5432 postgres:9.6 | |||
There was a problem hiding this comment.
don't we need to add net=host for postgres too?
There was a problem hiding this comment.
Nope, postgres container publishes 5432 port to host. It is shown to host as localhost at the side of clair container which is running in host network.
There was a problem hiding this comment.
Ok. I'll approve this change if you can fix the spelling mistake in the commit message.
Usage of Rrunning clair via docker is wrongly written. => Usage of running clair via docker is wrongly written.
Thanks! It's been a long time since I've used Docker directly on Linux (I use mac) and so I've forgotten the semantics of net=host.
There was a problem hiding this comment.
I fixed my spelling mistake and changed author to me.
jzelinskie
changed the title
Command line needs --net=host.
Usage of running clair via docker is wrongly written.
Command line needs --net=host when docker is used to run clair.