Custom notifiers #52
Merged
Custom notifiers #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Quentin-M this needs to be rebased |
Quentin-M
force-pushed
the
custom_notifiers
branch
from
56cedb3
to
8e7b294
Compare
| ) | ||
|
|
||
| // A HTTP notifier dispatches notifications to an HTTP endpoint. | ||
| type HTTP struct { |
There was a problem hiding this comment.
Can we rename this WebhookNotifier and s/http/webhook all over the place? I think that's more descriptive than the transport protocol (http).
- The notifier was never checking if it should shutdown if there were always at least one notification to send - After a failure, the notifier is supposed to back-off, but when Clair is stopping, the backoff was interrupted immediately and did not retry. Instead it selected a new notification to send (most likely: the same one) and looped quickly/weirdly.
Quentin-M
force-pushed
the
custom_notifiers
branch
from
91221b6
to
f4a4d41
Compare
|
LGTM |
jzelinskie
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.