Improvements to the helm chart #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration was merged with the comment line above due to usage of
the {{- ... -}} construct.
jzelinskie
suggested changes
Feb 10, 2018
contrib/helm/clair/values.yaml
Outdated
| tag: latest | ||
| pullPolicy: Always | ||
| repository: quay.io/coreos/clair | ||
| tag: v2.0.1 |
There was a problem hiding this comment.
Because this code is in master, it should be tied to deploying master. When we cut a stable release, we should tie this to a particular version.
- be more accurate in memory requests, so chair is scheduled on a host that has that space available. - add an explicit mention for the postgresql.enabled flag
|
Thanks for looking into this. I've updated my pull request to omit that image change! I do think it might be useful to mention this choice in the docs, so people can choose to install the stable version instead. I didn't get the master version running last week. |
jzelinskie
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'd like to fix the hurdles I've run into.
These are:
source: postgresURIline was merged the the comment above, because the if statement strips newlines at both ends.postgresql.enabledcan be set to false, because therequirements.yamlallows that.Do you also have plans to move this chart to the official helm chart repositories?