Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding publisher datetime and updating nvd feed download #571

Merged
merged 2 commits into from
Jul 17, 2018

Conversation

ErikThoreson
Copy link
Contributor

nvd.go and xml.go: added publisher datetime from xml feed and updated the XML feed download to complete before moving onto downloading the next feed

Reason:
The NVD site frequently resets connections when downloading the feeds if they are not downloaded in a timely manner. When all the feeds are requested at once but then not downloaded immediately the NVD site will reset the connection. It is more reliable to download each after making the request instead of opening all the connections then downloading them one at a time.
Also added is the Publication Datetime from the XML. This field is useful for compliance as many vulnerability programs for PCI base their remediation priority off this date field.

Example feed error:
{"Event":"could not decode NVD data feed","Level":"error","Location":"nvd.go:93","Time":"2017-08-25 18:48:15.515078","data feed name":"2014","error":"read tcp 192.168.10.9:54476-\u003e129.6.13.177:443: read: connection reset by peer"}

NOTE: This is a ref to this PR. Just a bit more cleaned up. #496

@jzelinskie jzelinskie merged commit b1cd092 into quay:master Jul 17, 2018
This was referenced Jul 17, 2018
@reasonerjt
Copy link
Contributor

@jzelinskie @ErikThoreson
Will this be cherry picked to release-2.0 branch?
I'm seeing the connection reset issue when using Clair 2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants