database: reduce pruneLocks/Unlock transaction. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,7 +68,6 @@ func Lock(name string, duration time.Duration, owner string) (bool, time.Time) { | |||
| func Unlock(name, owner string) { | |||
| pruneLocks() | |||
|
|
|||
| t := cayley.NewTransaction() | |||
| it, _ := cayley.StartPath(store, name).Has("locked", "locked").Has("locked_by", owner).Save("locked_until", "locked_until").BuildIterator().Optimize() | |||
There was a problem hiding this comment.
If the assumption is that this will only return one thing from the iterator, please verify it and log an error if your assumption is violated. The change to the transaction scope should be fine.
pruneLocks could create deadlocked transactions on PostgreSQL if multiple locks expired and pruneLocks is called by multiple instances. Also adds some logging.
|
LGTM |
Quentin-M
pushed a commit
that referenced
this pull request
Nov 16, 2015
database: reduce pruneLocks/Unlock transaction.
Quentin-M
pushed a commit
that referenced
this pull request
Feb 24, 2016
api: adjust postLayer error codes
Allda
added a commit
to Allda/clair
that referenced
this pull request
Apr 23, 2019
Filter out duplicated RPMs in higher layers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pruneLocks could create deadlocked transactions on PostgreSQL if multiple locks expired and pruneLocks is called by multiple instances because Cayley does not guarantee the order.
InsertNotifications and InsertVulnerabilities also insert multiple independent items in a single same transaction. Doing so in InsertNotifications helps because as the transaction only contains new quads, COPY can be used. For the same reason, it could not create a deadlocked transaction. In the other hand, InsertVulnerabilities may delete some fields. However, just like InsertNotifications, it is called from the updater - which run only once per cluster: it could not create a deadlocked transaction. Additionally, the updater relies on the fact that these two functions will fail and rollback entirely if any of the elements can't be inserted (for any reason) - in which case it will not mark the update as done and will redo it later. I believe that because of the reasons above, they should not be modified.