Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding httputil and version packages to master #606

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Adding httputil and version packages to master #606

merged 1 commit into from
Sep 6, 2018

Conversation

MackJM
Copy link
Contributor

@MackJM MackJM commented Sep 5, 2018

  • Debian/RHEL/Oracle vulnsrc now use httputil to download files
  • httputil sets the User-Agent to the requests as Clair/ (https://github.com/coreos/clair)
  • httputil holds Status2xx() which returns if the response is a http success (2xx)
  • GetClientAddr moved from api/httputil to pkg/httputil
  • the version packge holds a Version string which is set at build time from the git tag and sha
  • the .git directory was removed from .dockerignore so that we can use the git tag to set the version

@trend-jm-mackay
Adding httputil and version packages
9df4f5b 
- Debian/RHEL/Oracle vulnsrc now use httputil to download files
- httputil sets the User-Agent to the requests as Clair/<version> (https://github.com/coreos/clair/)
- httputil holds Status2xx() which returns if the response is a http success (2xx)
- GetClientAddr moved from api/httputil to pkg/httputil
- the version packge holds a Version string which is set at build time from the git tag and sha
- the .git directory was removed from .dockerignore so that we can use the git tag to set the version
jzelinskie
jzelinskie approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit 06b257c into quay:master Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzelinskie jzelinskie jzelinskie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MackJM @jzelinskie @trend-jm-mackay