Remove dependency on graceful #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardNerd
reviewed
Sep 6, 2018
api/api.go
Outdated
| if opErr, ok := err.(*net.OpError); !ok || (ok && opErr.Op != "accept") { | ||
| log.Fatal(err) | ||
| } | ||
| log.Fatal(err) |
There was a problem hiding this comment.
https://golang.org/pkg/net/http/#Server.Shutdown
By the example, ListenAndServe will return ErrServerClosed when Shutdown is called. Should we change it to be that only when err is not ErrServerClosed, we log Fatal.
This library has no longer been needed since Go 1.8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library has no longer been needed since Go 1.8 added
http.Server.Shutdown().