Replace Ancestry with AncestryWithContent struct in database models #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KeyboardNerd
added
kind/cleanup
jzelinskie
suggested changes
Sep 7, 2018
api/v3/rpc.go
Outdated
| } else { | ||
| dbAncestry, ok, err := tx.FindAncestry(name) | ||
| for _, layer := range ancestry.Layers { | ||
| pbLayer, err := GetPbAncestryLayer(tx, layer, req.GetWithFeatures(), req.GetWithVulnerabilities()) |
There was a problem hiding this comment.
I was actually thinking about totally removing these from the proto, too. Let's just always return everything.
There was a problem hiding this comment.
hmm idk if we want to always return the vulnerabilities though
There was a problem hiding this comment.
Quay almost exclusively requests with vulnerabilities. IIRC the only scenario it doesn't is in tests. Clients that don't care about the vulnerabilities can just ignore them and this avoids us maintaining this branch needlessly.
As one of the steps to simplifies the codebase, the AncestryWithContent struct is renamed to Ancestry, and Ancestry is removed. It will cause the PostAncestry request to be slower.
KeyboardNerd
force-pushed
the
sidac/simplify
branch
from
9b73d51
to
5d725e6
Compare
jzelinskie
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As one of the steps to simplifies the codebase, the AncestryWithContent
struct is renamed to Ancestry, and Ancestry is removed. It will cause
the PostAncestry request to be slower.