Introduce pkg/grpcutil #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was used for handling errors in the graceful library and was never necessary for the v3 API.
jzelinskie
added
kind/cleanup
pkg/grpcutil/gateway.go
Outdated
| if tlsConfig != nil { | ||
| var gwTLSConfig *tls.Config | ||
| gwTLSConfig = tlsConfig.Clone() | ||
| gwTLSConfig.InsecureSkipVerify = true |
There was a problem hiding this comment.
Can we add a comment on why we use InsecureSkipVerify here?
pkg/grpcutil/gateway.go
Outdated
|
|
||
| srvmux := runtime.NewServeMux( | ||
| // Include empty fields with default values. | ||
| runtime.WithMarshalerOption(runtime.MIMEWildcard, &runtime.JSONPb{EmitDefaults: true}), |
There was a problem hiding this comment.
Do you remember why do we want to include the empty fields?
There was a problem hiding this comment.
Yeah, just get rid of it, I don't think there will be any issues.
This change refactors gRPC code used within the v3 API package into generic code that can be used for managing gRPC and gRPC Gateway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors all of the gRPC code used in the v3 package to be generic and reusable.