database: remove LayerWithContent from interface #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KeyboardNerd
commented
Sep 11, 2018
KeyboardNerd
commented
- Layer is renamed to LayerMetadata
- LayerWithContent is renamed to Layer
- Remove redundant interfaces to pertain layer's metadata
|
After this, there will be a PR for relating features with Lister/Detector to enable the API wise filtering. |
jzelinskie
suggested changes
Sep 13, 2018
worker.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| log.WithFields( | ||
| log.Fields{ |
There was a problem hiding this comment.
put this on the line above
| j, _ := json.Marshal(m) | ||
| json.Unmarshal(j, &c) | ||
| return c | ||
| } |
There was a problem hiding this comment.
Why don't we need this anymore?
There was a problem hiding this comment.
No, we don't need it. We will not compare crafted MetadataMap against MetadataMap from database query result any more because Updater will only compare MetadataMaps from database.
There was a problem hiding this comment.
https://github.com/coreos/clair/blob/master/updater.go#L515 It may be by design that we will only create notification when there's big change in the vulnerability. Maybe, in the future we can make it configurable.
KeyboardNerd
force-pushed
the
sidac/rm_layer
branch
from
435f672
to
e160616
Compare
jzelinskie
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.