pkg/gitutil: init #621
Merged
pkg/gitutil: init #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
added
kind/cleanup
KeyboardNerd
suggested changes
Sep 15, 2018
| @@ -183,40 +182,6 @@ func parseVulnsFromNamespace(repositoryPath, namespace string) (vulns []database | |||
| return | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Wow.
Very duplication.
So Git.
pkg/gitutil/gitutil.go
Outdated
| var commandOutput []byte | ||
| commandOutput, err = cmd.CombinedOutput() | ||
| if err != nil { | ||
| os.RemoveAll(path) |
There was a problem hiding this comment.
log returned error
yeah, previously it wasn't handled at all.
pkg/gitutil/gitutil.go
Outdated
| func CloneOrPull(remote, desiredPath string) (path, head string, err error) { | ||
| // Create a temporary directory if the path is unspecified. | ||
| if desiredPath == "" { | ||
| path, err = ioutil.TempDir(os.TempDir(), remote) |
There was a problem hiding this comment.
I don't think we should use remote for the prefix
https://github.com/coreos/clair/pull/621/files#diff-154f97505971bb2f44a0f30045d133d2R38
We can use the updater flag I think.
pkg/gitutil/gitutil.go
Outdated
|
|
||
| // CloneOrPull performs a git pull if the desiredPath exists on the filesystem. | ||
| // Otherwise, it generates a new temporary directory and performs a git clone | ||
| // to that path. |
There was a problem hiding this comment.
Different from the documentation here, the code only generate a new temporary directory when the desired path is not given. Is that the expected behavior?
KeyboardNerd
suggested changes
Sep 18, 2018
pkg/gitutil/gitutil.go
Outdated
| } | ||
|
|
||
| // CloneOrPull performs a git pull if there is a git repository located at | ||
| // desiredPath. Otherwise, it performs a git clone to that path. |
This refactors the code we're using to manage temporary git repositories into a utility package.
KeyboardNerd
approved these changes
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code we're using to manage temporary git repositories
into a utility package.