vulnsrc: Refactor debian and alpine sources #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KeyboardNerd
commented
Oct 19, 2018
KeyboardNerd
commented
- Add fsutil to handle listing directory function
- Add FindKeyValue wrapper in database module
- Refactor debian and alpine sources to use them
KeyboardNerd
force-pushed
the
spkg/cvrf
branch
2 times, most recently
from
a4a291b
to
4baf1cd
Compare
jzelinskie
suggested changes
Oct 22, 2018
ext/vulnsrc/alpine/alpine_test.go
Outdated
| ) | ||
|
|
||
| func TestYAMLParsing(t *testing.T) { | ||
| _, filename, _, _ := runtime.Caller(0) | ||
| path := filepath.Join(filepath.Dir(filename)) | ||
| secdb, err := parseSecDBFile(path + "/testdata/v34_main.yaml") |
There was a problem hiding this comment.
We should use filepath.Join() again here instead of +.
While it's obvious now, we you refactor and change code, it becomes less obvious over time.
pkg/fsutil/fsutil.go
Outdated
|
|
||
| // Dir lists the files or folders under the given path and filter based on the | ||
| // dirFilter. | ||
| func Dir(path string, filter dirFilter) ([]string, error) { |
There was a problem hiding this comment.
I'd name this Readdir for transparency.
ext/vulnsrc/alpine/alpine.go
Outdated
| return | ||
| } | ||
|
|
||
| func extractVulnerabilities(file *secDBFile) (vulns []database.VulnerabilityWithAffected) { |
There was a problem hiding this comment.
This looks like a good place to make this a method and turn parseSecDBFile into a constructor:
secDBFile => secDB
parseSecDBFile => newSecDB
extractVulnerabilites => secDB.Vulnerabilities()
jzelinskie
added
kind/cleanup
* Update gopkg.in/yaml.v2 package and glide setting * Update other packages
KeyboardNerd
force-pushed
the
spkg/cvrf
branch
from
4baf1cd
to
4106322
Compare
|
Updated according to comments |
jzelinskie
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.