Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updater: remove FindLock(), use errgroup to avoid races #685

Merged
merged 12 commits into from
Feb 14, 2019
Merged

updater: remove FindLock(), use errgroup to avoid races #685

merged 12 commits into from
Feb 14, 2019

Conversation

jzelinskie
Copy link
Contributor

@jzelinskie jzelinskie commented Jan 10, 2019 •
edited

This addresses a race condition in the updater, and cleans up numerous minor issues.

@jzelinskie jzelinskie added kind/cleanup no functional changes, only reorganization component/database labels Jan 10, 2019
@jzelinskie
database: remove FindLock()
399deab
@jzelinskie
updater: refactor to use errgroup
6c5be7e 
This addresses a race condition and makes this code much more
understandable.
@jzelinskie
updater: reimplement fetch() with errgroup
0d41968 
This adds context support to a few more functions in the update process.
This makes progress towards to goal of having cancellable updates.
@jzelinskie
updater: remove original RunUpdate()
e16d17d
@jzelinskie
ext: add CleanAll() utility functions
25078ac
@jzelinskie
updater: extract deduplicate function
7084a22
@jzelinskie
glide: add errgroup and regenerate vendor
165c397
@jzelinskie jzelinskie changed the title Updater cleanup updater: remove FindLock(), use errgroup to avoid races Jan 10, 2019
KeyboardNerd
KeyboardNerd reviewed Feb 13, 2019
View reviewed changes
Copy link
Contributor

@KeyboardNerd KeyboardNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update mock.go

pkg/timeutil/timeutil.go Show resolved Hide resolved
pkg/timeutil/timeutil.go Show resolved Hide resolved
pkg/timeutil/timeutil.go Outdated Show resolved Hide resolved
updater.go Outdated Show resolved Hide resolved
updater.go Show resolved Hide resolved
KeyboardNerd
KeyboardNerd reviewed Feb 13, 2019
View reviewed changes
Copy link
Contributor

@KeyboardNerd KeyboardNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments, otherwise looks good.

updater.go Outdated Show resolved Hide resolved
@KeyboardNerd
Copy link
Contributor

please also remove this: https://github.com/coreos/clair/blob/master/database/mock.go#L51

KeyboardNerd
KeyboardNerd approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@KeyboardNerd KeyboardNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzelinskie jzelinskie merged commit cafe097 into quay:master Feb 14, 2019
@jzelinskie jzelinskie deleted the updater-cleanup branch February 14, 2019 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeyboardNerd KeyboardNerd KeyboardNerd approved these changes

Assignees
No one assigned
Labels
kind/cleanup no functional changes, only reorganization
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzelinskie @KeyboardNerd