Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make nodePort configurable with helm #700

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Make nodePort configurable with helm #700

merged 1 commit into from
Jan 30, 2019

Conversation

anon6789
Copy link
Contributor

This pull request adds option to set the NodePort to desired port. The port can be set with the following values file:

service:
   type: "NodePort"
   apiNodePort: 31111
   healthNodePort: 31112

Only when Values.service.type equals "NodePort" and Values.service.apiNodePort or Values.service.healthNodePort is specified the NodePort port will be set.

@jzelinskie jzelinskie added area/dev tooling related to tools used by developers area/distribution related to means of distributing the project labels Jan 30, 2019
jzelinskie
jzelinskie approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jzelinskie jzelinskie merged commit 11b26b3 into quay:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzelinskie jzelinskie jzelinskie approved these changes

Assignees
No one assigned
Labels
area/dev tooling related to tools used by developers area/distribution related to means of distributing the project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anon6789 @jzelinskie