v3: Analyze layer content in parallel #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
suggested changes
Mar 20, 2019
| return err | ||
| } | ||
|
|
||
| layerMap[layer.Hash] = clairLayer |
There was a problem hiding this comment.
This needs a lock even though the keys are independent because of races when the runtime is expanding the size of the map.
Even if we added the size to the make,layerMap := make(map[string]*database.Layer, len(req.Layers)), I wouldn't trust this race without a lock.
KeyboardNerd
force-pushed
the
parallel_download
branch
from
76e1f91
to
af9afdb
Compare
KeyboardNerd
force-pushed
the
parallel_download
branch
from
af9afdb
to
88f5069
Compare
jzelinskie
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the performance issue we see.