New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set / as default path but allow for individual configuration in values.yml #742

Merged

jzelinskie merged 1 commit into quay:master from bluelabsio:path-templating

Mar 26, 2019

Contributor

alsokate commented Mar 20, 2019 •

edited

Loading

The current hardcoded path / in the ingress template of the Helm charts does not work in the context of AWS ALBs. The listener is explicit in its routing, and the path needs to be set to /* in order for any of the requests to Clair endpoints to succeed. This is a fix that sets / as a default but allows for others using the same system to set a custom configuration without having to maintain their own copy of the Helm charts.

Viz:
(with default / path)

(with path configured to /* in a local, customized clone of the helm charts)


          helm: allow for ingress path configuration in values.yml

710c655

alsokate marked this pull request as ready for review

March 20, 2019 17:18

jzelinskie added area/usability component/contrib labels

Contributor

jzelinskie commented Mar 26, 2019

Hey there.

This is actually some default boilerplate generated with all Helm Charts, I believe.
You might be able to make this case upstream as well.

jzelinskie approved these changes

View reviewed changes

jzelinskie merged commit 3316e7e into quay:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment