Allow OpenShift user update CA bundle #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzelinskie
added
area/distribution
|
I'm not sure I'm comfortable with adding OpenShift specific fixes in the upstream project. Considering Red Hat only supports software built on a RHEL base image, the upstream Alpine-based image is already a no-go. Clair-JWT is a supported version of Clair for running on OpenShift for Quay deployments, and it is in the process of moving towards a RHEL base image. |
|
I'm not a huge fan of this, but I think it's reasonable with a comment in the Dockerfile so that it's not lost in the noise. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
When users run Clair in OpenShift under arbitrary user and they want to update CA bundle with their own certificate they need to run `ca-certificates` which requires access to /etc/ssl/certs. This commit updates Dockerfile based on OpenShift guidelines to allow update CA bundle in system. https://docs.openshift.com/container-platform/3.11/creating_images/guidelines.html#openshift-specific-guidelines
Allda
requested review from
jzelinskie,
KeyboardNerd,
ldelossa and
Quentin-M
as code owners
jzelinskie
approved these changes
Jul 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users run Clair in OpenShift under arbitrary user and
they want to update CA bundle with their own certificate
they need to run
ca-certificateswhich requires accessto /etc/ssl/certs.
This commit updates Dockerfile based on OpenShift guidelines to allow
update CA bundle in a system.
https://docs.openshift.com/container-platform/3.11/creating_images/guidelines.html#openshift-specific-guidelines