Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm local dev #788

Merged
merged 8 commits into from
Jun 5, 2019
Merged

Helm local dev #788

merged 8 commits into from
Jun 5, 2019

Conversation

ldelossa
Copy link
Contributor

@ldelossa ldelossa commented Jun 2, 2019

This PR implements a kubernetes driven local development environment. It's expected that kubernetes clusters be ran via minikube or docker desktop. If the developer decides to run kubernetes by a different manner they will just need to make sure their docker cli tool is configured to push build context to said kubernetes cluster.

A makefile is used to drive the local development environment. On first run of make deploy-local both a clair and a postgres instance are built and ran on the local kubernetes cluster. Subsequent calls to make deploy-local build a new container with the latest code in the working directory and only deploys clair, leaving any writes to the database intact.

Running make teardown-local will remove both the cliar and postgres instances from the local kubernetes.

Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good so far.

I actually wouldn't mind a commit that deletes the whole contrib directory in this PR.

README.md Show resolved Hide resolved
@jzelinskie jzelinskie added area/dev tooling related to tools used by developers area/usability related to improving user experience labels Jun 3, 2019
@ldelossa
Copy link
Contributor Author

ldelossa commented Jun 5, 2019

@jzelinskie if we remove the contrib dir all together, do we want to preserve anything in there like the grafana templates? We could potentially make them part of the local dev env also.

Documentation/local-development.md Outdated Show resolved Hide resolved
Documentation/local-development.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ldelossa ldelossa merged commit 849afac into quay:master Jun 5, 2019
@ldelossa ldelossa deleted the helm-local-dev branch June 6, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev tooling related to tools used by developers area/usability related to improving user experience
Development

Successfully merging this pull request may close these issues.

None yet

2 participants