base image version bump #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsamidurai
requested review from
jzelinskie,
KeyboardNerd,
ldelossa and
Quentin-M
as code owners
ldelossa
reviewed
Jul 17, 2019
|
|
||
|
|
||
| # change ownership of ssl directory to allow custom cert in OpenShift | ||
| RUN chgrp -R 0 /etc/ssl/certs && \ |
There was a problem hiding this comment.
@vsamidurai can you explain this a bit more? Are you expecting to use a volume to mount certs to this path?
KeyboardNerd
previously approved these changes
Jul 19, 2019
Dockerfile
Outdated
| COPY --from=build /go/src/github.com/coreos/clair/clair /clair | ||
| RUN apk add --no-cache git rpm xz ca-certificates dumb-init | ||
|
|
||
|
|
There was a problem hiding this comment.
thank you.. removed extra space
KeyboardNerd
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile base image version bump to fix multiple CVE.
gliderlabs/docker-alpine#430
#567