Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvd: fix conversion of r.StatusCode to string #839

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

noahklein-zz
Copy link
Contributor

string(404) == "Ɣ"
fmt.Sprintf("%d", 404) == "404"

See https://play.golang.org/p/_avQPvVyLJ4

string(404) == "Ɣ"
fmt.Sprintf("%d", 404) == "404"

See https://play.golang.org/p/_avQPvVyLJ4
@noahklein-zz noahklein-zz changed the title Fix conversion of r.StatusCode to string nvd: fix conversion of r.StatusCode to string Sep 4, 2019
@jzelinskie jzelinskie added component/ext/vulnmdsrc kind/bug things are not as they seem labels Sep 5, 2019
Copy link
Contributor

@jzelinskie jzelinskie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!
Great first contribution!

@jzelinskie jzelinskie merged commit 34c01e3 into quay:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug things are not as they seem
Development

Successfully merging this pull request may close these issues.

None yet

3 participants