Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quota UI: Adding Overall storage consumption for Super users panel page (PROJQUAY-3639) #1307

Merged
merged 1 commit into from May 10, 2022

Conversation

Sunandadadi
Copy link
Contributor

@Sunandadadi Sunandadadi commented May 9, 2022

Screen Shot 2022-05-10 at 10 26 02 AM

return;
}
let total = 0;
$scope.organizations.forEach(function (obj){
Copy link
Member

@kleesc kleesc May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if just doing a sum over the repositorysize table would be better. It would keep it to a single table operation, easier to cache, etc... as opposed to going through every single organization in the registry, which involves selecting from the tag and manifest tables.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e have a superuser specific endpoint that just does this repositorysize table aggregation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the Quota Consumption data for every org under quota_report key. So, instead of making another API call, we are using the data the /organizations endpoint is fetching.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I guess that panel is already fetching the complete list of organization.

@Sunandadadi Sunandadadi requested a review from kleesc May 9, 2022 19:49
Copy link
Member

@kleesc kleesc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunandadadi Sunandadadi merged commit 587cceb into quay:master May 10, 2022
@Sunandadadi Sunandadadi deleted the registry-quota branch May 10, 2022 18:47
@HammerMeetNail
Copy link
Contributor

/cherry-pick redhat-3.7

@openshift-cherrypick-robot

@HammerMeetNail: new pull request created: #1314

In response to this:

/cherry-pick redhat-3.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants