Confirmation prompt on repo deletion #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
josephschorr
reviewed
Jun 9, 2020
crozzy
previously approved these changes
Jun 29, 2021
- When deleting a repository, a prompt will show requiring the user to enter <namespace>/<repository> - Delete button will be disabled until text matches the namespace
jonathankingfc
force-pushed
the
require_namespace_deletion
branch
from
f42306f
to
471c343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added confirmation form when deleting a repository. The user must type in namespace/repo in order to delete repository. See images below:
Changes:
Issue: https://issues.redhat.com/browse/PROJQUAY-763
Reviewer Checklist
@kurtismullins
@josephschorr