Stops working in Electron as of v5.0.0

[tribou]

Hi!

I'm trying to share code across a web app and Electron, and it's been working great on v4. However, when I try to upgrade this package in the Electron app from v4.1.0 to v5.0.0 (or later), all of the network calls silently stop working. v5 appears to still work in the web app with the exact same API code.

Has anyone else gotten version v5.0.0 or later to work with Electron?

[qubyte]

The one thing which I suspect is making an issue for you is this line.

Edit: Not sure where I was reading webpack. A reduction would still help though!

[tribou]

Ah, I thought that was the culprit as well until yesterday when I noticed that v5.0.1 wasn't working either even though it has the previous version of that logic here. So now I'm wondering if it is somehow the upgrade to node-fetch@v2.0.0...even though that doesn't make as much sense as the line you referenced.

Let me see if I can get a couple example branches up to compare. Unfortunately, it's a pretty large app at the moment. Also, I believe it's still on webpack v3 if that helps at all.

[tribou]

After "unmasking" my API helpers, I was able to log the error:

And this is fetch-node.js:15.

Any thoughts?

[qubyte]

It's not possible to know what's going on without a little more information. Is this running in Node or in a BrowserWindow? I don't know much about electron, but I suspect you want the browser half of fetch ponyfill rather than the Node half. Try using require('fetch-ponyfill/build/fetch-browser.js') and see if you get any further with that.

If that doesn't work for you, then a modern enough electron (which would still be quite old) will support genuine fetch out of the box. If you're fetching in Node, then this module delegates to fetch-node anyway, which might be a better option for you.

[qubyte]

This may also be pertinent: electron/electron#1574

[qubyte]

@tribou How did you get on?

[tribou]

My apologies, I didn't make much more progress. I've still got v4.1.0 pinned for now until I can find time to debug more.

[d-fischer]

This seems to still be an issue.